docs(turbopack): Document build dependency on clang for rocksdb #72493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
approved these changes
Nov 14, 2024
wyattjoh
pushed a commit
that referenced
this pull request
Nov 28, 2024
Noticed this after rebuilding on top of #71688 Most Linux distributions default to `gcc` for their default `cc` implementation (e.g. via Debian's `build-essential` meta-package, which we can probably implicitly assume is installed), which means that they won't typically have `clang` installed. `librocksdb-sys` seems to always depend on `clang` on Linux. It looks like this might be a consequence of using [rust-bindgen](https://github.com/rust-lang/rust-bindgen) (though I'm confused why this didn't come up earlier), as it looks like rocksdb can otherwise build with gcc. This shouldn't be an issue for macos, since `clang` is the default `cc` on that platform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this after rebuilding on top of #71688
Most Linux distributions default to
gccfor their defaultccimplementation (e.g. via Debian'sbuild-essentialmeta-package, which we can probably implicitly assume is installed), which means that they won't typically haveclanginstalled.librocksdb-sysseems to always depend onclangon Linux. It looks like this might be a consequence of using rust-bindgen (though I'm confused why this didn't come up earlier), as it looks like rocksdb can otherwise build with gcc.This shouldn't be an issue for macos, since
clangis the defaultccon that platform.Closes PACK-3492